X-Git-Url: http://git.kpe.io/?a=blobdiff_plain;f=mop.lisp;h=9925c0f99fcd704acd874b26cc6c1685a5d34fcb;hb=da57e4f1ef6bef626996ce87fca1abf225274128;hp=f10dd7388a9ef6b989412a2656a3b32432a7f7be;hpb=6c6ef7e865aba5106164df13ceefb4e4454c54cb;p=hyperobject.git

diff --git a/mop.lisp b/mop.lisp
index f10dd73..9925c0f 100644
--- a/mop.lisp
+++ b/mop.lisp
@@ -11,7 +11,7 @@
 ;;;; in Text, HTML, and XML formats. This includes hyperlinking
 ;;;; capability and sub-objects.
 ;;;;
-;;;; $Id: mop.lisp,v 1.44 2003/04/12 05:16:54 kevin Exp $
+;;;; $Id: mop.lisp,v 1.63 2003/04/25 05:00:58 kevin Exp $
 ;;;;
 ;;;; This file is Copyright (c) 2000-2002 by Kevin M. Rosenberg
 ;;;;
@@ -84,7 +84,11 @@
 
 (defclass hyperlink ()
   ((name :type symbol :initform nil :initarg :name :reader name)
-   (lookup :type function :initform nil :initarg :lookup :reader lookup)
+   (lookup
+    ;; The type specifier seems to break sbcl
+    ;; :type (or function symbol)
+    :type t
+    :initform nil :initarg :lookup :reader lookup)
    (link-parameters :type list :initform nil :initarg :link-parameters
 		    :reader link-parameters)))
 
@@ -117,7 +121,7 @@
 					     value)
       (when (and ,required (null value))
 	(error "hyperobject class slot ~A must have a value" name))
-      (list name value))
+      (list name `',value))
     #+(or allegro sbcl cmu scl)
     (declare (ignore slot-name required))
     )
@@ -129,7 +133,7 @@
 					    value
 					    already-processed-options
 					    slot)
-      (list* option value already-processed-options))
+      (list* option `',value already-processed-options))
     #-lispworks
     (declare (ignore slot-name))
     )
@@ -191,33 +195,15 @@
     (t
      t)))
 
-#+(or sbcl cmu scl)
-(defmethod compute-effective-slot-definition :around ((cl hyperobject-class) dsds)
-  (let* ((dsd (car dsds))
-	 (value-type (canonicalize-value-type (slot-value dsd 'value-type))))
-    (multiple-value-bind (sql-type length) (value-type-to-sql-type value-type)
-      (setf (slot-value dsd 'sql-type) sql-type)
-      (setf (slot-value dsd 'type) (value-type-to-lisp-type value-type))
-      (let ((ia (compute-effective-slot-definition-initargs
-		 cl #+lispworks name dsds)))
-	(apply
-	 #'make-instance 'hyperobject-esd 
-	 :value-type value-type
-	 :sql-type sql-type
-	 :length length
-	 :print-formatter (slot-value dsd 'print-formatter)
-	 :subobject (slot-value dsd 'subobject)
-	 :hyperlink (slot-value dsd 'hyperlink)
-	 :hyperlink-parameters (slot-value dsd 'hyperlink-parameters)
-	 :description (slot-value dsd 'description)
-	 :user-name (slot-value dsd 'user-name)
-	 :index (slot-value dsd 'index)
-	 :value-constraint (slot-value dsd 'value-constraint)
-	 :null-allowed (slot-value dsd 'null-allowed)
-	 ia)))))
+(eval-when (:compile-toplevel :load-toplevel :execute)
+  (when (>= (length (generic-function-lambda-list
+		     (ensure-generic-function
+		      'compute-effective-slot-definition)))
+	    3)
+    (push :ho-named-cesd-fun cl:*features*)))
 
 (defmethod compute-effective-slot-definition :around ((cl hyperobject-class)
-						      #+(or lispworks allegro)
+						      #+ho-named-cesd-fun name
 						      dsds)
   #+allegro (declare (ignore name))
   (let* ((dsd (car dsds))
@@ -241,25 +227,29 @@
 	 :value-constraint (slot-value dsd 'value-constraint)
 	 :null-allowed (slot-value dsd 'null-allowed)
 	 ia)))))
-  
+
+
+#+ho-named-cesd-fun
+(setq cl:*features* (delete :ho-named-cesd-fun cl:*features*))
+
 (defun value-type-to-lisp-type (value-type)
   (case (if (atom value-type)
 	    value-type
 	    (car value-type))
     ((:string :cdata :varchar :char)
-     'string)
+     '(or null string))
     (:character
-     'character)
+     '(or null character))
     (:fixnum
-     'fixnum)
+     '(or null fixnum))
     (:boolean
-     'boolean)
+     '(or null boolean))
     (:integer
-     'integer)
+     '(or null integer))
     ((:float :single-float)
-     'single-float)
+     '(or null single-float))
     (:double-float
-     'double-float)
+     '(or null double-float))
     (otherwise
      t)))
 
@@ -302,8 +292,8 @@
     `(defmethod slot-unbound (,the-class (,the-instance ,class)
 			      (,the-slot-name (eql ',slot-name)))
       (declare (ignore ,the-class))
-      (setf (slot-value ,the-instance ,the-slot-name)
-       (,reader ,@keys)))))
+      (setf (slot-value ,the-instance ,the-slot-name) (,reader ,@keys)))))
+
 
 #+lispworks
 (defun intern-eql-specializer (slot)