X-Git-Url: http://git.kpe.io/?a=blobdiff_plain;f=sql%2Foodml.lisp;h=9aff2c8dab99a36b930d09c103340b1125961abe;hb=814ef0649edf23f0136d5cad2d7738ae72e79871;hp=3e7ec9af023c31fc1c5d0e4cdd538c4ab2e8cfa5;hpb=5bd17e4032ba3987db4af25b89fc939056896512;p=clsql.git

diff --git a/sql/oodml.lisp b/sql/oodml.lisp
index 3e7ec9a..9aff2c8 100644
--- a/sql/oodml.lisp
+++ b/sql/oodml.lisp
@@ -189,11 +189,14 @@
                                    (db-value-from-slot slot val database))))
                        slots)))
     (cond ((and avps (view-database obj))
-           (update-records (sql-expression :table vct)
-                           :av-pairs avps
-                           :where (key-qualifier-for-instance
-                                   obj :database database)
-                           :database database))
+	   (let ((where (key-qualifier-for-instance
+			 obj :database database)))
+	     (unless where
+	       (error "update-record-from-slots: Could not generate a where clause for this object: ~a" obj))
+	     (update-records (sql-expression :table vct)
+			     :av-pairs avps
+			     :where where
+			     :database database)))
           ((and avps (not (view-database obj)))
            (insert-records :into (sql-expression :table vct)
                            :av-pairs avps
@@ -470,8 +473,12 @@
     (format nil "~F" val)))
 
 (defmethod read-sql-value (val type database db-type)
-  (declare (ignore type database db-type))
-  (read-from-string val))
+  (declare (ignore database db-type))
+  (cond
+    ((null type) val) ;;we have no desired type, just give the value
+    ((typep val type) val) ;;check that it hasn't already been converted.
+    ((typep val 'string) (read-from-string val)) ;;maybe read will just take care of it?
+    (T (error "Unable to read-sql-value ~a as type ~a" val type))))
 
 (defmethod read-sql-value (val (type (eql 'string)) database db-type)
   (declare (ignore database db-type))
@@ -867,6 +874,10 @@ maximum of MAX-LEN instances updated in each query."
           (car objects)
         objects))))
 
+(defmethod select-table-sql-expr ((table T))
+  "Turns an object representing a table into the :from part of the sql expression that will be executed "
+  (sql-expression :table (view-table table)))
+
 (defun find-all (view-classes
                  &rest args
                  &key all set-operation distinct from where group-by having
@@ -880,8 +891,6 @@ maximum of MAX-LEN instances updated in each query."
   (flet ((ref-equal (ref1 ref2)
            (string= (sql-output ref1 database)
                     (sql-output ref2 database)))
-         (table-sql-expr (table)
-           (sql-expression :table (view-table table)))
          (tables-equal (table-a table-b)
            (when (and table-a table-b)
              (string= (string (slot-value table-a 'name))
@@ -907,15 +916,15 @@ maximum of MAX-LEN instances updated in each query."
            (fullsels (apply #'append (mapcar #'append sels immediate-join-sels)))
            (sel-tables (collect-table-refs where))
            (tables (remove-if #'null
-                              (remove-duplicates
-                               (append (mapcar #'table-sql-expr sclasses)
-                                       (mapcan #'(lambda (jc-list)
-                                                   (mapcar
-                                                    #'(lambda (jc) (when jc (table-sql-expr jc)))
-                                                    jc-list))
-                                               immediate-join-classes)
-                                       sel-tables)
-                               :test #'tables-equal)))
+			      (remove-duplicates
+			       (append (mapcar #'select-table-sql-expr sclasses)
+				       (mapcan #'(lambda (jc-list)
+						   (mapcar
+						    #'(lambda (jc) (when jc (select-table-sql-expr jc)))
+						    jc-list))
+					       immediate-join-classes)
+				       sel-tables)
+			       :test #'tables-equal)))
            (order-by-slots (mapcar #'(lambda (ob) (if (atom ob) ob (car ob)))
                                    (listify order-by)))
            (join-where nil))