X-Git-Url: http://git.kpe.io/?a=blobdiff_plain;f=sql-classes.lisp;h=d1dcc91b8c0dc0eedf97c6f98d619383a115e48e;hb=4ff5c6265dbda842ccbccadb0138999792be3f74;hp=bdb79bd767e77863baa23a2f0209f8b64d9b2462;hpb=a6eadf9e6d566a0342fccba766fb02f97a969a5a;p=umlisp.git

diff --git a/sql-classes.lisp b/sql-classes.lisp
index bdb79bd..d1dcc91 100644
--- a/sql-classes.lisp
+++ b/sql-classes.lisp
@@ -7,7 +7,7 @@
 ;;;; Author:        Kevin M. Rosenberg
 ;;;; Date Started:  Apr 2000
 ;;;;
-;;;; $Id: sql-classes.lisp,v 1.32 2003/05/03 20:08:21 kevin Exp $
+;;;; $Id: sql-classes.lisp,v 1.39 2003/05/03 20:32:40 kevin Exp $
 ;;;;
 ;;;; This file, part of UMLisp, is
 ;;;;    Copyright (c) 2000-2002 by Kevin M. Rosenberg, M.D.
@@ -26,25 +26,24 @@
 (defun current-srl! (srl)
   (setq *current-srl* srl))
 
-
 (defmacro with-umlisp-query ((table fields srl where-name where-value
 				    &key (lrlname "KCUILRL") distinct single
 				    order like)
 			     &body body)
-  (let ((query (gensym)))
+  (if single
+    `(unless (and ,where-name (not ,where-value)) 
+      (let ((tuple (car (umlisp-query ,table ,fields ,srl ,where-name ,where-value
+				      :lrlname ,lrlname :single ,single
+				      :distinct ,distinct :order ,order :like ,like))))
+	(when tuple
+	  (destructuring-bind ,fields tuple
+	    ,@body))))
     `(unless (and ,where-name (not ,where-value)) 
-      (let ((,query (umlisp-query ,table (quote ,fields) ,srl ,where-name ,where-value
-				  :lrlname ,lrlname :single ,single :distinct ,distinct
-				  :order ,order :like ,like)))
-	(if ,single
-	    (let ((tuple (car ,query)))
-	      (when tuple
-		(destructuring-bind ,fields tuple
-		  ,@body)))
-	    (loop
-	     for tuple in ,query collect
-	     (destructuring-bind ,fields tuple
-	       ,@body)))))))
+      (loop for tuple in
+       (umlisp-query ,table ,fields ,srl ,where-name ,where-value
+	:lrlname ,lrlname :single ,single :distinct ,distinct :order ,order :like ,like)
+       collect (destructuring-bind ,fields tuple
+		 ,@body)))))
 
 (defmacro umlisp-query (table fields srl where-name where-value
 		     &key (lrlname "KCUILRL") single distinct order like)
@@ -60,22 +59,20 @@ is OBJNAME from TABLE where WHERE-NAME field = WHERE-VALUE with FIELDS"
 			&key (lrlname "KCUILRL") single distinct order like)
   (let* ((%%fields (format nil "select ~A~{~:@(~A~)~^,~} from ~:@(~A~)"
 			   (if distinct "distinct " "") fields table))
-	 (%%order (if order (format nil " order by ~{~:@(~A~) ~(~A~)~^,~}" order) "")))
+	 (%%order (if order (format nil " order by ~{~:@(~A~) ~(~A~)~^,~}" order) ""))
+	 (%%lrl (format nil " and ~:@(~A~) <= ~~D" lrlname)))
     `(concatenate
       'string
       ,%%fields
       (if ,where-name
-	  (format nil
-		  (if (stringp ,where-value)
-		      (if ,like
-			  " where ~A like '%~A%'"
-			  " where ~A='~A'")
-		      " where ~A=~A")
+	  (format nil (if (stringp ,where-value)
+			  (if ,like " where ~A like '%~A%'" " where ~A='~A'")
+			  " where ~A=~A")
 		  ,where-name ,where-value)
 	  "")
-      (if ,srl (format nil " and ~:@(~A~) <= ~D" ,lrlname ,srl) "")
-      ,%%order
-      (if ,single " limit 1" ""))))
+      (if ,srl (format nil ,%%lrl ,srl) "")
+      ,@(when %%order (list %%order))
+      ,@(when ,single (" limit 1")))))
 
 (defun query-string (table fields &optional srl where-name where-value
 		     &key (lrlname "KCUILRL") single distinct order like)
@@ -111,10 +108,10 @@ is OBJNAME from TABLE where WHERE-NAME field = WHERE-VALUE with FIELDS"
       (when srl
 	(string-append ls (format nil " and KCUILRL <= ~d" srl)))
       (string-append ls " limit 1")
-      (awhen (car (mutex-sql-query ls))
-	     (destructuring-bind (kpfstr kcuilrl)
-		 (make-instance 'ucon :cui cui :pfstr kpfstr
-			    :lrl (ensure-integer kcuilrl)))))))
+      (let ((tuple (car (mutex-sql-query ls))))
+	(destructuring-bind (kpfstr kcuilrl) tuple
+	  (make-instance 'ucon :cui cui :pfstr kpfstr
+			 :lrl (ensure-integer kcuilrl)))))))
 
 (defun find-ucon-cui-sans-pfstr (cui &key (srl *current-srl*))
   "Find ucon for a cui"