X-Git-Url: http://git.kpe.io/?p=clsql.git;a=blobdiff_plain;f=sql%2Fpool.lisp;h=1ac0a37b5b550374c0a55d0fd58b60feae0a220a;hp=6791a6e272368ad232d2318856248b743d74cd98;hb=9ba5ee2647740aca7777ac12a21db32837f3f2b6;hpb=6f9c91e01227e25e36560220628269258c80712d diff --git a/sql/pool.lisp b/sql/pool.lisp index 6791a6e..1ac0a37 100644 --- a/sql/pool.lisp +++ b/sql/pool.lisp @@ -33,8 +33,28 @@ (defun acquire-from-conn-pool (pool) (or (with-process-lock ((conn-pool-lock pool) "Acquire from pool") - (and (plusp (length (free-connections pool))) - (vector-pop (free-connections pool)))) + (when (plusp (length (free-connections pool))) + (let ((pconn (vector-pop (free-connections pool)))) + ;; test if connection still valid. + ;; Currently, on supported on MySQL + (cond + ((eq :mysql (database-type pconn)) + (handler-case + (database-query "SHOW ERRORS LIMIT 1" pconn nil nil) + (error (e) + ;; we could check for error type 2006 for "SERVER GONE AWAY", + ;; but, it's safer just to disconnect the pooled conn for any error + (warn "Database connection ~S had an error when attempted to be acquired from the pool: + ~S +Disconnecting.~%" + pconn e) + (ignore-errors (database-disconnect :database pconn)) + nil) + (:no-error (res fields) + (declare (ignore res fields)) + pconn))) + (t + pconn))))) (let ((conn (connect (connection-spec pool) :database-type (pool-database-type pool) :if-exists :new