X-Git-Url: http://git.kpe.io/?p=clsql.git;a=blobdiff_plain;f=sql%2Fpool.lisp;h=457315560bc5499c494c4da3a5e5e87f25050d7b;hp=b0e228f2be7b297d57a714b5e028cb23b457c91c;hb=e567409d9fff3f7231c2a0bb69b345e19de2b246;hpb=8a8ee2d7d791b7a3efaed06420802a925d16fca3

diff --git a/sql/pool.lisp b/sql/pool.lisp
index b0e228f..4573155 100644
--- a/sql/pool.lisp
+++ b/sql/pool.lisp
@@ -25,23 +25,44 @@
   ((connection-spec :accessor connection-spec :initarg :connection-spec)
    (database-type :accessor pool-database-type :initarg :pool-database-type)
    (free-connections :accessor free-connections
-		     :initform (make-array 5 :fill-pointer 0 :adjustable t))
+                     :initform (make-array 5 :fill-pointer 0 :adjustable t))
    (all-connections :accessor all-connections
-		    :initform (make-array 5 :fill-pointer 0 :adjustable t))
+                    :initform (make-array 5 :fill-pointer 0 :adjustable t))
    (lock :accessor conn-pool-lock
-	 :initform (make-process-lock "Connection pool"))))
+         :initform (make-process-lock "Connection pool"))))
 
 (defun acquire-from-conn-pool (pool)
   (or (with-process-lock ((conn-pool-lock pool) "Acquire from pool")
-	(and (plusp (length (free-connections pool)))
-	     (vector-pop (free-connections pool))))
+        (when (plusp (length (free-connections pool)))
+          (let ((pconn (vector-pop (free-connections pool))))
+            ;; test if connection still valid.
+            ;; Currently, on supported on MySQL
+            (cond
+              ((eq :mysql (database-type pconn))
+               (handler-case
+                   (database-query "SHOW ERRORS LIMIT 1" pconn nil nil)
+                 (error (e)
+                   ;; we could check for error type 2006 for "SERVER GONE AWAY",
+                   ;; but, it's safer just to disconnect the pooled conn for any error
+                   (warn "Database connection ~S had an error when attempted to be acquired from the pool:
+  ~S
+Disconnecting.~%"
+                         pconn e)
+                   (ignore-errors (database-disconnect pconn))
+                   nil)
+                 (:no-error (res fields)
+                   (declare (ignore res fields))
+                   pconn)))
+              (t
+               pconn)))))
       (let ((conn (connect (connection-spec pool)
-			   :database-type (pool-database-type pool)
-			   :if-exists :new)))
-	(with-process-lock ((conn-pool-lock pool) "Acquire from pool")
-	  (vector-push-extend conn (all-connections pool))
-	  (setf (conn-pool conn) pool))
-	conn)))
+                           :database-type (pool-database-type pool)
+                           :if-exists :new
+                           :make-default nil)))
+        (with-process-lock ((conn-pool-lock pool) "Acquire from pool")
+          (vector-push-extend conn (all-connections pool))
+          (setf (conn-pool conn) pool))
+        conn)))
 
 (defun release-to-conn-pool (conn)
   (let ((pool (conn-pool conn)))
@@ -51,8 +72,9 @@
 (defun clear-conn-pool (pool)
   (with-process-lock ((conn-pool-lock pool) "Clear pool")
     (loop for conn across (all-connections pool)
-	  do (setf (conn-pool conn) nil)
-	  (disconnect :database conn))
+          do (setf (conn-pool conn) nil)
+          ;; disconnect may error if remote side closed connection
+          (ignore-errors (disconnect :database conn)))
     (setf (fill-pointer (free-connections pool)) 0)
     (setf (fill-pointer (all-connections pool)) 0))
   nil)
@@ -62,12 +84,12 @@
 if not found"
   (with-process-lock (*db-pool-lock* "Find-or-create connection")
     (let* ((key (list connection-spec database-type))
-	   (conn-pool (gethash key *db-pool*)))
+           (conn-pool (gethash key *db-pool*)))
       (unless conn-pool
-	(setq conn-pool (make-instance 'conn-pool
-				       :connection-spec connection-spec
-				       :pool-database-type database-type))
-	(setf (gethash key *db-pool*) conn-pool))
+        (setq conn-pool (make-instance 'conn-pool
+                                       :connection-spec connection-spec
+                                       :pool-database-type database-type))
+        (setf (gethash key *db-pool*) conn-pool))
       conn-pool)))
 
 (defun acquire-from-pool (connection-spec database-type &optional pool)
@@ -83,8 +105,8 @@ if not found"
   (with-process-lock (*db-pool-lock* "Disconnect pooled")
     (maphash
      #'(lambda (key conn-pool)
-	 (declare (ignore key))
-	 (clear-conn-pool conn-pool))
+         (declare (ignore key))
+         (clear-conn-pool conn-pool))
      *db-pool*)
     (when clear (clrhash *db-pool*)))
   t)
@@ -93,13 +115,13 @@ if not found"
 ;  "Start all stream in the pool recording actions of TYPES"
 ;  (dolist (con (pool-connections pool))
 ;    (start-sql-recording :type types
-;			 :database (connection-database con))))
+;                        :database (connection-database con))))
 
 ;(defun pool-stop-sql-recording (pool &key (types :command))
 ;  "Start all stream in the pool recording actions of TYPES"
 ;  (dolist (con (pool-connections pool))
 ;    (stop-sql-recording :type types
-;			  :database (connection-database con))))
+;                         :database (connection-database con))))
 
 ;(defmacro with-database-connection (pool &body body)
 ;  `(let ((connection (obtain-connection ,pool))