X-Git-Url: http://git.kpe.io/?p=clsql.git;a=blobdiff_plain;f=sql%2Fsyntax.lisp;h=68fa8aad7462b2e5ccacffc82d7271537a7d81b1;hp=eb19060c4b6ad655eab3c542d1a1482aa03a7925;hb=HEAD;hpb=528064c179b6b74f0a9d6a43c42e71de3f0e9a3a

diff --git a/sql/syntax.lisp b/sql/syntax.lisp
index eb19060..68fa8aa 100644
--- a/sql/syntax.lisp
+++ b/sql/syntax.lisp
@@ -1,8 +1,6 @@
 ;;;; -*- Mode: LISP; Syntax: ANSI-Common-Lisp; Base: 10 -*-
 ;;;; *************************************************************************
 ;;;;
-;;;; $Id$
-;;;;
 ;;;; CLSQL square bracket symbolic query syntax. Functions for
 ;;;; enabling and disabling the syntax and for building SQL
 ;;;; expressions using the syntax.
@@ -16,9 +14,7 @@
 
 (in-package #:clsql-sys)
 
-(defvar *original-reader-enter* nil)
-
-(defvar *original-reader-exit* nil)
+(defvar *original-readtable* nil)
 
 (defvar *sql-macro-open-char* #\[)
 
@@ -45,9 +41,9 @@ the current syntax state."
     (%disable-sql-reader-syntax)))
 
 (defun %disable-sql-reader-syntax ()
-  (when *original-reader-enter*
-    (set-macro-character *sql-macro-open-char* *original-reader-enter*))
-  (setf *original-reader-enter* nil)
+  (when *original-readtable*
+    (setf *readtable* *original-readtable*
+          *original-readtable* nil))
   (values))
 
 
@@ -68,11 +64,21 @@ the current syntax state."
   '(eval-when (:compile-toplevel :load-toplevel :execute)
     (%enable-sql-reader-syntax)))
 
+(defmacro file-enable-sql-reader-syntax ()
+  "Turns on the SQL reader syntax for the rest of the file.
+The CL spec says that when finished loading a file the original
+*readtable* is restored.  clhs COMPILE-FILE"
+  '(eval-when (:compile-toplevel :load-toplevel :execute)
+    (setf *readtable* (copy-readtable))
+    (set-macro-character *sql-macro-open-char* #'sql-reader-open)
+    (set-macro-character *sql-macro-close-char* (get-macro-character #\)))))
+
 (defun %enable-sql-reader-syntax ()
-  (unless *original-reader-enter*
-    (setf *original-reader-enter* (get-macro-character *sql-macro-open-char*)))
-  (set-macro-character *sql-macro-open-char* #'sql-reader-open)
-  (enable-sql-close-syntax)
+  (unless *original-readtable*
+    (setf *original-readtable* *readtable*
+          *readtable* (copy-readtable))
+    (set-macro-character *sql-macro-open-char* #'sql-reader-open)
+    (set-macro-character *sql-macro-close-char* (get-macro-character #\))))
   (values))
 
 (defmacro restore-sql-reader-syntax-state ()
@@ -88,50 +94,52 @@ reader syntax is disabled."
 (defun sql-reader-open (stream char)
   (declare (ignore char))
   (let ((sqllist (read-delimited-list #\] stream t)))
-    (cond ((string= (write-to-string (car sqllist)) "||")
-           (cons (sql-operator 'concat-op) (cdr sqllist)))
-          ((and (= (length sqllist) 1) (eql (car sqllist) '*))
-           (apply #'generate-sql-reference sqllist))
-          ((sql-operator (car sqllist))
-           (cons (sql-operator (car sqllist)) (cdr sqllist)))
-          (t (apply #'generate-sql-reference sqllist)))))
-
-(defun disable-sql-close-syntax ()
-  "Internal function that disables the close syntax when leaving
-  sql context."
-  (set-macro-character *sql-macro-close-char* *original-reader-exit*)
-  (setf *original-reader-exit* nil))
-
-(defun enable-sql-close-syntax ()
-  "Internal function that enables close syntax when entering SQL
-  context."
-  (setf *original-reader-exit* (get-macro-character *sql-macro-close-char*))
-  (set-macro-character *sql-macro-close-char* (get-macro-character #\))))
+    (unless *read-suppress*
+      (handler-case
+          (cond ((string= (write-to-string (car sqllist)) "||")
+                 (cons (sql-operator 'concat-op) (cdr sqllist)))
+                ((and (= (length sqllist) 1) (eql (car sqllist) '*))
+                 (apply #'generate-sql-reference sqllist))
+                ((sql-operator (car sqllist))
+                 (cons (sql-operator (car sqllist)) (cdr sqllist)))
+                (t (apply #'generate-sql-reference sqllist)))
+        (sql-user-error (c)
+          (error 'sql-user-error
+                 :message (format nil "Error ~A occured while attempting to parse '~A' at file position ~A"
+                                  (sql-user-error-message c) sqllist (file-position stream))))))))
 
 (defun generate-sql-reference (&rest arglist)
-  (cond ((= (length arglist) 1)	; string, table or attribute
-	 (if (stringp (car arglist))
-	     (sql-expression :string (car arglist))
-             (sql-expression :attribute (car arglist))))
-	((<= 2 (length arglist))
-	 (let ((sqltype (when (keywordp (caddr arglist)) (caddr arglist) nil)))
+  (cond ((= (length arglist) 1) ; string, table or attribute
+         (let ((arg (first arglist)))
+           (typecase arg
+             (string (sql-expression :string arg))
+             (symbol ;; handle . separated names
+              (let* ((sn (symbol-name arg))
+                     (idx (position #\. sn)))
+                (cond
+                  (idx (sql-expression :table (intern (subseq sn 0 idx))
+                                       :attribute (intern (subseq sn (+ idx 1))) ))
+                  (T (sql-expression :attribute arg))))
+              ))))
+        ((<= 2 (length arglist))
+         (let ((sqltype (when (keywordp (caddr arglist)) (caddr arglist) nil)))
            (cond
              ((stringp (cadr arglist))
-	     (sql-expression :table (car arglist)
-			     :alias (cadr arglist)
-			     :type sqltype))
-	    ((keywordp (cadr arglist))
-	     (sql-expression :attribute (car arglist)
-			     :type (cadr arglist)))
-	    (t
-	     (sql-expression :attribute (cadr arglist)
-			     :table (car arglist)
-			     :type sqltype)))))
-	(t
-	 (error 'sql-user-error :message "bad expression syntax"))))
-
-
-;; Exported functions for dealing with SQL syntax 
+             (sql-expression :table (car arglist)
+                             :alias (cadr arglist)
+                             :type sqltype))
+            ((keywordp (cadr arglist))
+             (sql-expression :attribute (car arglist)
+                             :type (cadr arglist)))
+            (t
+             (sql-expression :attribute (cadr arglist)
+                             :table (car arglist)
+                             :type sqltype)))))
+        (t
+         (error 'sql-user-error :message "bad expression syntax"))))
+
+
+;; Exported functions for dealing with SQL syntax
 
 (defun sql (&rest args)
   "Returns an SQL string generated from the expressions ARGS. The
@@ -155,7 +163,7 @@ keyword arguments is specified."
     (string
      (make-instance 'sql :string string))
     (attribute
-     (make-instance 'sql-ident-attribute  :name attribute
+     (make-instance 'sql-ident-attribute :name attribute
                     :qualifier (or table alias)
                     :type type))
     ((and table (not attribute))
@@ -183,8 +191,8 @@ function and the remaining values in ARGS its arguments as
 strings."
   (if (sql-operator operator)
       (apply (symbol-function (sql-operator operator)) args)
-      (error 'sql-user-error 
-             :message 
+      (error 'sql-user-error
+             :message
              (format nil "~A is not a recognized SQL operator." operator))))