r10039: * BUGS: New file. Document suspected SIGPIPE

        interaction between SBCL and libpq used in
        postgresql backend.
        * sql/package.lisp: Export *default-caching*
        * sql/oodml.lisp: Use *default-caching* to
        control default caching behavior.

diff --git a/BUGS b/BUGS
new file mode 100644 (file)
index 0000000..2f96768
--- /dev/null
+++ b/BUGS
@@ -0,0 +1,9 @@
+1. SBCL/Postgresql Interaction
+
+Gabor Melis reported an interaction with SBCL and the postgresql
+database backend using a multithreaded program and Portable
+AllegroServe. It appears that libpg installs its own SIGPIPE
+handler. When a multithreaded program servicing socket requests has
+SIGPIPE conditions thrown, the running SBCL instance is killed.  The
+web page http://linux.com.hk/docs/postgresql/libpq-threading.html has
+more information about libpq's SIGPIPE handler.

diff --git a/ChangeLog b/ChangeLog
index f3459ca73a78c532d8e879f7715cc55423fdbfb4..57745b2d0b3684d5c20a26da79bb53da5b01b036 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+28 Sep 2004 Kevin Rosenberg <kevin@rosenberg.net>
+       * BUGS: New file. Document suspected SIGPIPE
+       interaction between SBCL and libpq used in
+       postgresql backend.
+       * sql/package.lisp: Export *default-caching*
+       * sql/oodml.lisp: Use *default-caching* to 
+       control default caching behavior.
+       
 21 Sep 2004 Kevin Rosenberg <kevin@rosenberg.net>
        * Version 3.0.5 release
        * doc/appendix.xml: Add note about loading Oracle8 version

diff --git a/sql/oodml.lisp b/sql/oodml.lisp
index c98342ed55ddf3ce220ec7c5d9ddf86ad3c8ff4d..77617e7932a23f0cf0fc9daf9d3247e2d0168c31 100644 (file)
--- a/sql/oodml.lisp
+++ b/sql/oodml.lisp
@@ -984,6 +984,10 @@ maximum of MAX-LEN instances updated in each query."
 
 (defmethod instance-refreshed ((instance standard-db-object)))
 
+(defvar *default-caching* t
+  "Controls whether SELECT caches objects by default. The CommonSQL
+specification states caching is on by default.")
+
 (defun select (&rest select-all-args) 
    "Executes a query on DATABASE, which has a default value of
 *DEFAULT-DATABASE*, specified by the SQL expressions supplied
@@ -1042,7 +1046,7 @@ as elements of a list."
        
        (cond
          ((select-objects target-args)
-          (let ((caching (getf qualifier-args :caching t))
+          (let ((caching (getf qualifier-args :caching *default-caching*))
                 (result-types (getf qualifier-args :result-types :auto))
                 (refresh (getf qualifier-args :refresh nil))
                 (database (or (getf qualifier-args :database) *default-database*))

diff --git a/sql/package.lisp b/sql/package.lisp
index 38fcaf7f28f4fca080791918169daefee4378810..8351ef3e147a2dd25c5d6da1aad02bbd983ab853 100644 (file)
--- a/sql/package.lisp
+++ b/sql/package.lisp
@@ -360,6 +360,7 @@
         #:instance-refreshed               
         #:update-objects-joins             
         #:*default-update-objects-max-len* 
+        #:*default-caching*
         #:update-slot-from-record          
         #:update-instance-from-records     
         #:update-records-from-instance