Store walltimes as timestamptz by default in postgres

 * This removes significant ambiguity from working with
   datetimes and by all accounts *should* be default
   now that we can correctly track it

re ADWolf:#1408

diff --git a/ChangeLog b/ChangeLog
index 29ac560c8302fc0f5b8fdf1aeeeb9880f468de14..8b393e6e9c184ac9cb816ace6a75a5a1e718d3f7 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2018-02-04 Russ Tyndall <russ@acceleration.net>
+       * sql/generic-postgres.lisp:    
+       Wall times default to being timestamptz in postgresql now.
+       There was a TODO questioning why it was storing zoneless by
+       default - it was because of the bugs about tracking UTC
+       vs zoneless
+
+       
 2018-02-03 Russ Tyndall <russ@acceleration.net>
        * sql/time.lisp, tests/time.lisp:       
        Better distinguishing between zoneless timestamps and UTC times,

diff --git a/sql/generic-postgresql.lisp b/sql/generic-postgresql.lisp
index 13d4f7714d1445c10be31cdf5b267b9310f73de3..2464746f11c9b4a2de764487a88cc68c5089858f 100644 (file)
--- a/sql/generic-postgresql.lisp
+++ b/sql/generic-postgresql.lisp
@@ -25,8 +25,10 @@
   "Special database types for POSTGRESQL backends"
   (declare (ignore database db-type))
   (case type
-    (wall-time ;; TODO: why is this WITHOUT...
-     "TIMESTAMP WITHOUT TIME ZONE")
+    ;; his used to be without because we didnt track timezones well
+    ;; Now we do, so it should include them
+    (wall-time
+     "TIMESTAMP WITH TIME ZONE")
     (string
      ;; TODO: the default to CHAR here seems specious as the PG docs claim
      ;; that char is slower than varchar