From: Russ Tyndall <russ@acceleration.net>
Date: Thu, 24 Feb 2011 18:39:02 +0000 (-0500)
Subject: fixed :from clauses to not throw errors when presented with a string or string expression
X-Git-Tag: v6.0.0~4^2~26
X-Git-Url: http://git.kpe.io/?p=clsql.git;a=commitdiff_plain;h=e25a98d30a030b33bcb78d1903811b6e71963216

fixed :from clauses to not throw errors when presented with a string or string expression
---

diff --git a/sql/expressions.lisp b/sql/expressions.lisp
index efb54bb..b808064 100644
--- a/sql/expressions.lisp
+++ b/sql/expressions.lisp
@@ -602,14 +602,16 @@ uninclusive, and the args from that keyword to the end."
       (output-sql (apply #'vector selections) database))
     (when from
       (write-string " FROM " *sql-stream*)
-      (flet ((ident-table-equal (a b)
-               (and (if (and (eql (type-of a) 'sql-ident-table)
-                             (eql (type-of b) 'sql-ident-table))
-                        (string-equal (slot-value a 'alias)
-                                      (slot-value b 'alias))
-                        t)
-                    (string-equal (sql-escape (slot-value a 'name))
-                                  (sql-escape (slot-value b 'name))))))
+      (labels ((ident-string-val (a)
+                 (typecase a
+                   (sql-ident
+                    (or (ignore-errors (slot-value a 'alias))
+                        (ignore-errors (slot-value a 'name))))
+                   (string a)))
+               (ident-table-equal (a b)
+                 ;; The things should be type compatable
+                 (string-equal (ident-string-val a)
+                               (ident-string-val b))))
         (typecase from
           (list (output-sql (apply #'vector
                                    (remove-duplicates from